Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: reset headers timeout on headers complete #34578

Closed
wants to merge 3 commits into from
Closed

http: reset headers timeout on headers complete #34578

wants to merge 3 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 31, 2020 •
edited

headers timeout should not occur after headers have been received.

Fixes: #34576

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4184

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http Issues or PRs related to the http subsystem. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. labels Jul 31, 2020
@ronag
http: reset headers timeout on headers complete
118a7e8 
headers timeout should not occur *after* headers have been
received.

Fixes: nodejs#34576
@ronag ronag requested a review from addaleax July 31, 2020 12:44
@ronag
Copy link
Member Author

ronag commented Jul 31, 2020

@nodejs/http

addaleax
addaleax approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/http

@ronag ronag added the v14.x label Jul 31, 2020
@ronag
Copy link
Member Author

ronag commented Jul 31, 2020 •
edited

I'm not sure why this doesn't fail more often pre this PR...

This was referenced Jul 31, 2020
Closed
Closed
@ronag ronag requested review from bnoordhuis and indutny July 31, 2020 13:39
@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 31, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32574/

indutny
indutny approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@indutny indutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Aug 1, 2020
Open
Open
Open
Open
@ronag
Copy link
Member Author

ronag commented Aug 2, 2020

Landed in da4d8de

ronag added a commit to nxtedition/node that referenced this pull request Aug 3, 2020
@ronag
test: fix flaky http-parser-timeout-reset
d7feec7 
Refs: nodejs#34578 (comment)
@ronag ronag mentioned this pull request Aug 3, 2020
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Aug 3, 2020
@ronag @MylesBorins
test: fix flaky http-parser-timeout-reset
8d8090b 
Refs: #34578 (comment)

PR-URL: #34609
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Aug 4, 2020
Open
Open
Open
Open
codebytere pushed a commit that referenced this pull request Aug 5, 2020
@ronag @codebytere
http: reset headers timeout on headers complete
7322e58 
headers timeout should not occur *after* headers have been
received.

Fixes: #34576

PR-URL: #34578
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
This was referenced Aug 6, 2020
Open
Open
codebytere pushed a commit that referenced this pull request Aug 6, 2020
@ronag @codebytere
test: fix flaky http-parser-timeout-reset
a340587 
Refs: #34578 (comment)

PR-URL: #34609
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Aug 7, 2020
Open
Open
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@ronag @codebytere
test: fix flaky http-parser-timeout-reset
283f5c3 
Refs: #34578 (comment)

PR-URL: #34609
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@orgads orgads mentioned this pull request Oct 26, 2020
Closed
4 tasks
@Flarna Flarna mentioned this pull request Oct 26, 2020
Closed
orgads pushed a commit to orgads/node that referenced this pull request Oct 26, 2020
@ronag @orgads
http: reset headers timeout on headers complete
0573a69 
headers timeout should not occur *after* headers have been
received.

Fixes: nodejs#35661

PR-URL: nodejs#34578
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
(cherry picked from commit da4d8de)
codebytere pushed a commit that referenced this pull request Nov 2, 2020
@ronag @codebytere
http: reset headers timeout on headers complete
9f3e888 
headers timeout should not occur *after* headers have been
received.

Fixes: #35661

PR-URL: #34578
Backport-PR-URL: #35819
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
(cherry picked from commit da4d8de)
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@ronag @MylesBorins
http: reset headers timeout on headers complete
f10d721 
headers timeout should not occur *after* headers have been
received.

Fixes: #35661

PR-URL: #34578
Backport-PR-URL: #35819
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
(cherry picked from commit da4d8de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indutny indutny indutny approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@rexagod rexagod rexagod approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Parser issues with newline \n
10 participants
@ronag @nodejs-github-bot @richardlau @indutny @jasnell @addaleax @lpinca @rexagod @Flarna @rickyes